Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): ensure props and attrs are shallow readonly in dev #8222

Closed
wants to merge 6 commits into from
Closed

fix(runtime-core): ensure props and attrs are shallow readonly in dev #8222

wants to merge 6 commits into from

Conversation

edison1105
Copy link
Member

fix #8216

@ferferga
Copy link
Contributor

ferferga commented May 8, 2023

@edison1105 Why just in dev?

@edison1105
Copy link
Member Author

@edison1105 Why just in dev?

see #8216 (comment)

What is actually happening?
It normally modifies the count in the child component and is the latest value when the count is printed without any effect.
I found that switching to the dev version of the Vue SFC Playground does have this problem, and whenever you switch to prod there is a warning

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.7 kB 34.5 kB 31.1 kB
vue.global.prod.js 148 kB 53.8 kB 48 kB

Usages

Name Size Gzip Brotli
createApp 50.8 kB 19.9 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53.1 kB 20.6 kB 18.8 kB
overall 64.5 kB 24.9 kB 22.6 kB

@edison1105 edison1105 changed the title fix(runtime-core): ensure props are shallow readonly in dev fix(runtime-core): ensure props and attrs are shallow readonly in dev Apr 21, 2024
@skirtles-code skirtles-code mentioned this pull request Apr 22, 2024
Closed
@edison1105
Copy link
Member Author

close due to #8216 has been fix via a7cf742

@edison1105 edison1105 closed this Apr 23, 2024
@skirtles-code skirtles-code mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirtles-code skirtles-code skirtles-code left review comments

Assignees
No one assigned
Labels
None yet
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why can I just change count and update it in the child component?
3 participants
@edison1105 @ferferga @skirtles-code